Repository navigation
feat(ui): share the main window logic - #234
Merged
Merged
Conversation
Move the GNOME main window's logic into ui as MainWindowController. The platform injects file, settings, clipboard, notification, help and share services; the GNOME window keeps the template and keys. WindowBehaviour uses the gjsify 0.63 window members on all three platforms: is-active pauses a running program, close-request is guarded, notify::focus-widget follows the focus inside the window. Suffix files skip what NativeScript refuses (focus-widget notify, window size persistence) and what the browser owns (window size). Android and web attach the behaviour to their own shells.
The workflows still installed 0.51.1 while the workspace is on 0.63.0.
Both platforms now build their main window on the shared MainWindowController through a MainWindowShell of their own and inject files, clipboard, notifier and share services. The unsaved-changes close guard stays unwired on both: the Android back button and Adw.Window on the web emit no close-request in gjsify yet.
JumpLink
force-pushed
the
feat/shared-main-window
branch
from
October 13, 2026 09:28
d3853e6 to
99fe79d
Compare
JumpLink
marked this pull request as ready for review
October 13, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #233 (gjsify 0.63.0).
MainWindowControllerin@learn6502/ui: the GNOME main window's navigation, run/step/assemble flow, files and unsaved-changes handling, layout mounting. Services (files, settings, clipboard, notifier, help, share) are injected.WindowBehaviour: gjsify 0.63 window members on all platforms (is-activeauto-pause,close-requestguard,notify::focus-widgeton desktop layouts).window-focus.android.ts(NS refuses the focus notify),window-size{,.android,.web}.ts(NS maximized is constant, unmaximize throws; the browser owns its size).WindowBehaviourto their shells. Their own shells (MainController, web MainWindow) are not yet replaced by the controller.close-requestyet.