Skip to content

Added BasicSymbolic as input for function fed to derivative #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025

Conversation

kapple19
Copy link
Contributor

@kapple19 kapple19 commented Sep 4, 2024

And fixed TypeError usage.

Should hopefully be enough to close #1085.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (ff30ebf) to head (a58baa0).
Report is 28 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   80.58%   80.57%   -0.01%     
==========================================
  Files          51       51              
  Lines        5136     5144       +8     
==========================================
+ Hits         4139     4145       +6     
- Misses        997      999       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisRackauckas
Copy link
Member

Can this get tests?

@kapple19
Copy link
Contributor Author

I should have time this weekend to look this through. I was confused as to how to write tests for this change.

@ChrisRackauckas
Copy link
Member

Bump?

@kapple19
Copy link
Contributor Author

kapple19 commented Jun 18, 2025

Is this test sufficient @ChrisRackauckas ?
I don't fully understand the BasicSymbolic infrastructure.
Sorry I forgot about this.

@ChrisRackauckas ChrisRackauckas merged commit da85a95 into JuliaSymbolics:master Jun 18, 2025
16 of 17 checks passed
@kapple19 kapple19 deleted the #1085 branch June 18, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing function to derivative results in zero
3 participants