Skip to content

Fix error on 0.0 with format "g/G" #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix error on 0.0 with format "g/G" #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
783608a
Fix 0.0 giving InexactError in g/G due to log10(0)
R3G3N3R4T0R Sep 5, 2025
267dc28
Add testset for format "g/G"
R3G3N3R4T0R Sep 9, 2025
9ad7ab2
Fix rounding before exponent for "g/G"
R3G3N3R4T0R Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fmtcore.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ end

function _pfmt_g(out::IO, fs::FormatSpec, x::AbstractFloat)
# Branch according to the exponent
expnt = floor(Int, log10(abs(x)) )
ax = round(abs(x) ;sigdigits=fs.prec)
expnt = ax == 0 ? 0 : floor(Int, log10(ax) )
if -4 <= expnt < fs.prec
newprec = fs.prec - expnt - 1
_pfmt_f(out, FormatSpec(fs ;prec=newprec), x)
Expand Down
58 changes: 58 additions & 0 deletions test/fmtspec.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,58 @@ end
@test pyfmt(".1e", 0.0006) == "6.0e-04"
end

# This testset is currently non-compliant to Python's format_spec
# Trailing insignificant zeros should be removed, however it is not done in
# the current implementation.
# FIXME: Make g/G compliant with Python's behavior
@testset "Format general (g/G)" begin
# Default precision (6 significant digits)
@test pyfmt("g", 123.456789) == "123.457"
@test pyfmt("g", 1.234567e-5) == "1.23457e-05"

# Switch between fixed and scientific depending on precision
# and exponent -> Issue #91 (Format.jl)
@test pyfmt(".3g", 0.0012345) == "0.00123"
@test pyfmt(".3g", 1234567.0) == "1.23e+06"
@test pyfmt(".2g", 0.000012345) == "1.2e-05"
@test pyfmt(".2g", 1e-4) == "0.00010"
@test pyfmt("g", 1e5) == "100000"
@test pyfmt("g", 1e6) == "1.00000e+06"

# Trailing zero and decimal point trimming
@test pyfmt(".6g", 1200.0) == "1200.00"
@test pyfmt(".4g", 12.0) == "12.00"

# Alternate form '#' keeps trailing zeros and decimal point
@test pyfmt("#.4g", 12.0) == "12.00"
@test pyfmt("#.3g", 1.0e-5) == "1.00e-05"

# Width, alignment, and zero-padding
@test pyfmt(">8.3g", 13.89) == " 13.9"
@test pyfmt("⋆<8.3g", 13.89) == "13.9⋆⋆⋆⋆"
@test pyfmt("⋆^8.3g", 13.89) == "⋆⋆13.9⋆⋆"
@test pyfmt("010.3g", 13.89) == "00000013.9"
@test pyfmt("010.3g", -13.89) == "-0000013.9"
@test pyfmt("+010.3g", 13.89) == "+0000013.9"

# Rounding across powers of ten
@test pyfmt(".3g", 9.999) == "10.0"
@test pyfmt(".3g", 9.999e9) == "1.00e+10"
@test pyfmt(".3g", -9.999e-5) == "-0.000100"
@test pyfmt(".3g", -9.999e-6) == "-1.00e-05"

# 'G' behaves like 'g' but uses 'E'
@test pyfmt(".3G", 1234567.0) == "1.23E+06"
@test pyfmt(".3G", 0.000012345) == "1.23E-05"
@test pyfmt("G", 12.0) == "12.0000"
@test pyfmt("#.4G", 12.0) == "12.00"
@test pyfmt("G", 1e6) == "1.00000E+06"

# Zeros, from regression of (04baaf3)
@test pyfmt("g", 0.0) == "0.00000"
@test pyfmt("g", -0.0) == "-0.00000"
end

@testset "Format percentage (%)" begin
@test pyfmt("8.2%", 0.123456) == " 12.35%"
@test pyfmt("<8.2%", 0.123456) == "12.35% "
Expand All @@ -355,18 +407,24 @@ end

@test pyfmt("f", NaN) == "NaN"
@test pyfmt("e", NaN) == "NaN"
@test pyfmt("g", NaN) == "NaN"
@test pyfmt("f", NaN32) == "NaN"
@test pyfmt("e", NaN32) == "NaN"
@test pyfmt("g", NaN32) == "NaN"

@test pyfmt("f", Inf) == "Inf"
@test pyfmt("e", Inf) == "Inf"
@test pyfmt("g", Inf) == "Inf"
@test pyfmt("f", Inf32) == "Inf"
@test pyfmt("e", Inf32) == "Inf"
@test pyfmt("g", Inf32) == "Inf"

@test pyfmt("f", -Inf) == "-Inf"
@test pyfmt("e", -Inf) == "-Inf"
@test pyfmt("g", -Inf) == "-Inf"
@test pyfmt("f", -Inf32) == "-Inf"
@test pyfmt("e", -Inf32) == "-Inf"
@test pyfmt("g", -Inf32) == "-Inf"

@test pyfmt("<5f", Inf) == "Inf "
@test pyfmt("^5f", Inf) == " Inf "
Expand Down
Loading