Skip to content

Use libsuitesparseconfig from JLL #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

Conversation

staticfloat
Copy link
Contributor

This prevents us from being influenced by things like LD_LIBRARY_PATH, and ensures that we always load the correct libsuitesparseconfig that came with our JLL.

This prevents us from being influenced by things like `LD_LIBRARY_PATH`,
and ensures that we always load the correct `libsuitesparseconfig` that
came with our JLL.
@staticfloat
Copy link
Contributor Author

This should fix JuliaInterop/JuliaCall#224

@staticfloat staticfloat added backport 1.10 backport 1.11 backport 1.12 Change should be backported to release-1.12 labels May 6, 2025
Copy link

codecov bot commented May 6, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (16bbcbc) to head (a1d6999).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/solvers/cholmod.jl 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
- Coverage   84.18%   83.97%   -0.22%     
==========================================
  Files          12       12              
  Lines        9265     9265              
==========================================
- Hits         7800     7780      -20     
- Misses       1465     1485      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 7b6e810 into main May 9, 2025
11 of 13 checks passed
@ViralBShah ViralBShah deleted the sf/use_jll_library_objects branch May 9, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.10 backport 1.11 backport 1.12 Change should be backported to release-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants