-
Notifications
You must be signed in to change notification settings - Fork 15
Improve documentation and fix docstrings #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tmigot
commented
Dec 17, 2025
- Fix docstring rendering
- Add link to GenericExecutionStats
- Write down NLP/NLS in solvers.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves documentation across multiple solver files by adding hyperlinks to GenericExecutionStats, fixing docstring formatting issues, and expanding acronyms in the solver documentation table.
Key changes:
- Added clickable markdown links to
GenericExecutionStatsdocumentation across all solver files - Fixed docstring rendering by adding proper line breaks between the opening
"""and function signatures - Expanded NLP/NLS acronyms to their full names in the solvers table
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/trunkls.jl | Added hyperlink to GenericExecutionStats documentation |
| src/trunk.jl | Added hyperlink to GenericExecutionStats documentation |
| src/tronls.jl | Added hyperlink to GenericExecutionStats documentation and fixed two docstring formats with proper line breaks |
| src/tron.jl | Added hyperlink to GenericExecutionStats documentation, fixed two docstring formats with proper line breaks, and corrected spacing in parameter σ |
| src/lbfgs.jl | Added hyperlink to GenericExecutionStats documentation |
| src/fomo.jl | Added hyperlink to GenericExecutionStats documentation |
| docs/src/solvers.md | Expanded NLP to "Nonlinear Optimization Problem" and NLS to "Nonlinear Least Squares" in the problem types table |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Related to #337 @dourouc05 can you have a look at this PR regarding changes you suggested ?
Could you expand a bit on what you mean here ? In the docstring of each solver, there is a section regarding callback, for instance https://jso.dev/JSOSolvers.jl/previews/PR339/reference/#JSOSolvers.TronSolver . |
|
About the callbacks, here is what I mean:
It's nearly always the same text, which means that you could have a section that explains that and you could refer to it in each function (instead of having a copy of the same blob everywhere). |
|
Oh, I see. It's actually a docstring here https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/blob/main/src%2FJSOSolvers.jl#L14 that we refer in each solver. I will think of a better way |
1 similar comment
|
Oh, I see. It's actually a docstring here https://github.com/JuliaSmoothOptimizers/JSOSolvers.jl/blob/main/src%2FJSOSolvers.jl#L14 that we refer in each solver. I will think of a better way |