Add tuple-pattern return, ConnectConfig, and API improvements#10
Closed
kalidke wants to merge 11 commits intofeature/smlmdata-0.6-compatfrom
Closed
Add tuple-pattern return, ConnectConfig, and API improvements#10kalidke wants to merge 11 commits intofeature/smlmdata-0.6-compatfrom
kalidke wants to merge 11 commits intofeature/smlmdata-0.6-compatfrom
Conversation
BREAKING: frameconnect() now returns (combined, info) instead of NamedTuple - Add ConnectInfo struct with track assignments and algorithm metadata - Capture timing with elapsed_ns field - Include n_input, n_tracks, n_combined, n_preclusters counts - Rate parameters (k_on, k_off, k_bleach, p_miss) accessible via info - Update all tests, examples, and documentation - Bump version to 0.4.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add ConnectConfig with @kwdef for algorithm parameters - Support both calling conventions: - frameconnect(smld, config::ConnectConfig) - frameconnect(smld; kwargs...) forwards to config form - Export ConnectConfig from module - All 115 tests pass Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- README: Add Configuration section with kwargs and config struct examples - api_overview: Add ConnectConfig type, update frameconnect signatures Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ConnectConfig <: AbstractSMLMConfig, ConnectInfo <: AbstractSMLMInfo from SMLMData v0.6.0 (feature/tuple-pattern c366f68). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ctInfo Namespace-qualified type names across struct definitions, exports, tests, docs, README, and api_overview.md. Zero old names remain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove dev/path dependency override. SMLMData now resolves from General registry as v0.7.0 (requires AbstractSMLMConfig/Info types). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Renames: nnearestclusters→n_density_neighbors, nsigmadev→max_sigma_dist, maxframegap→max_frame_gap, nmaxnn→max_neighbors, initialdensity→initial_density. Also removes redundant `using SMLMData` from doc examples (re-exported). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
actions/cache v1 was deprecated by GitHub, causing immediate CI failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frameconnect()now returns(combined, info)tuple instead of NamedTupleConnectInfostruct with track assignments and algorithm metadataConnectConfigstruct for reusable configuration (kwargs also supported)elapsed_sfield (Float64 seconds)n_input,n_tracks,n_combined,n_preclustersinfo.k_on,info.k_off, etc.New API
ConnectConfig Fields
nnearestclustersnsigmadevmaxframegapnmaxnnTest plan
🤖 Generated with Claude Code