Add covariance fields to Emitter2DFit and Emitter3DFit (v0.6.0) #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Emitter2DFit: add σ_xy for 2D uncertainty ellipse rotation - Emitter3DFit: add σ_xy, σ_xz, σ_yz for full 3D covariance matrix - All covariance fields default to zero(T) in convenience constructors - Show methods display covariances only when non-zero - Bump version to 0.6.0 (breaking: struct field order changed) Enables proper uncertainty visualization for astigmatic PSFs and tilted/rotated localization uncertainties from CRLB. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add σ_xy field to Emitter2DFit struct definitions - Add σ_xy, σ_xz, σ_yz fields to Emitter3DFit struct definitions - Update constructor examples to show covariance parameters Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
σ_xyfield toEmitter2DFitfor x-y covariance (microns²)σ_xy,σ_xz,σ_yzfields toEmitter3DFitfor full 3D covarianceBreaking Changes
Emitter2DFit struct: New
σ_xyfield inserted betweenσ_yandσ_photonsEmitter2DFit{T}(x, y, photons, bg, σ_x, σ_y, σ_photons, σ_bg, frame, ...)Emitter2DFit{T}(x, y, photons, bg, σ_x, σ_y, σ_xy, σ_photons, σ_bg, frame, ...)Emitter3DFit struct: New
σ_xy,σ_xz,σ_yzfields addedEcosystem Testing
All JuliaSMLM packages tested successfully with 0.6:
🤖 Generated with Claude Code