Fix SCMOSCamera matrix convention to match Julia standard #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_validate_camera_paramto expect(ny, nx)instead of(nx, ny)for calibration matrices[row, col]indexingDetails
The validation check for calibration matrices (readnoise, gain, offset, qe) was expecting
size(param) == (nx, ny), but Julia arrays useA[row, col]indexing. For a camera withnxcolumns andnyrows, matrices should be(ny, nx).Bug impact:
map[y, x]Why it wasn't caught:
(nx, ny) == (ny, nx)Test plan
map[y, x]🤖 Generated with Claude Code