-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Targets v0.1.0 #113040
New package: Targets v0.1.0 #113040
Conversation
JuliaRegistrator
commented
Aug 13, 2024
•
edited
Loading
edited
- Registering package: Targets
- Repository: https://github.com/codedthinking/Targets.jl
- Created by: @korenmiklos
- Version: v0.1.0
- Commit: ca3d1ef5c83a930d8b6ada70b363bb0edf475851
- Reviewed by: @korenmiklos
- Reference: Register on General codedthinking/Targets.jl#3 (comment)
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
UUID: 911cb31e-70cd-4e9d-a353-3054e2e6a3a8 Repo: https://github.com/codedthinking/Targets.jl.git Tree: a56a62719789ed8a5058168918aa55b7f84b8c1b Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
3b2573c
to
86e8842
Compare
The names Markets and Targets are sufficiently distinct so that they will not be mistaken. The name Targets is motivated by https://cran.r-project.org/package=targets. Please merge. [noblock] |
Can I suggest |
Targets is a much better name both because it is short and the usual name for these types of objects. GNU Make defines "targets", the corresponding R library is called "targets". [noblock] |
Well, “short” is not something we optimize for. The naming guidelines emphasize “Err on the side of clarity, even if clarity seems long-winded to you.” Naming conventions in R or other languages are different from Julia and are not a good guide. When [noblock] |
Not to dogpile 😅, but from a glance at the package it does seem like a more verbose name might benefit this package. In particular I'm thinking of these two guidelines from https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines
With that second point in particular, "targets" can only mean one thing in GNU Make, but there are both multiple ways of interpreting "Targets" in the context of Julia, and approaching this problem[1]. While this package is one interpretation/approach, it seems slightly presumptuous (to me at least) to claim the most generic name. [1]: For example DataFlowTasks.jl does "targets" within a single function, and DataToolkit.jl does this for computed datasets. [noblock] |
Thank you all for your valuable input on the package naming. I'd like to make a case for retaining "Targets":
While it may appear broad, I believe it's sufficiently clear for the intended users and accurately reflects the package's scope. A longer name might not enhance clarity in this case. I'm open to your thoughts if you feel I've overlooked any important considerations. Your expertise in the Julia ecosystem is invaluable. Thank you again for your time and insights. [noblock] |
As discussed by the OP, |
[noblock] I think I can come around to |
@korenmiklos Your first comment |