Don't use BrailleCanvas for vertical histogram by default#440
Merged
Conversation
topolarity
force-pushed
the
ct/fix-histogram-braille
branch
from
June 8, 2026 22:24
d5650d0 to
cf80984
Compare
The vertical histogram uses Unicode Block Elements (U+2580–U+259F) for most of its diagram, but it inherits its "blank space" Braille (U+2800) character from the active canvas. In the terminal this works fine since everything is monospace, but in browsers this often causes visual mis-alignment since, e.g., on macOS the default fonts give Braille characters a different spacing.
topolarity
force-pushed
the
ct/fix-histogram-braille
branch
from
June 9, 2026 00:39
cf80984 to
c9ce848
Compare
Contributor
Author
|
Not related to this PR anyway |
Member
|
Oh I see you are right, vertical histogram have slightly diverged from the original implementation of horizontal histograms which are using I have to cleanup the implementation at some point but your fix is very much valid. |
t-bltg
approved these changes
Jun 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vertical histogram uses Unicode Block Elements (U+2580–U+259F) for most of its diagram, but it inherits its "blank space" Braille (U+2800) character from the active canvas.
In the terminal this works fine since everything is monospace, but in browsers this often causes visual mis-alignment since, e.g., on macOS the default fonts give Braille characters a different spacing.
Before:
After:
The remaining mis-alignment issues in the browser are due to Github, Slack, etc. using a
font-familythat causes some glyphs to be filled in by one font and others to be provided by another. We can't do much about that, but at least we can fix this