Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the slow but constant increase in memory usage #209

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

NathanKolbow
Copy link
Contributor

The garbage collector does not get called by default in the snaq optimization loop, so memory slowly grows out of control for long optimizations.

Memory usage graph before this change:

before

Memory usage graph after this change:

after

@cecileane
Copy link
Member

thanks for this work! This change looks good to me.

@crsl4
Copy link
Member

crsl4 commented Feb 18, 2024

Looks good to me too!

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f46226c) 86.79% compared to head (b84ac74) 86.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   86.79%   86.84%   +0.05%     
==========================================
  Files          31       31              
  Lines       12635    12638       +3     
==========================================
+ Hits        10966    10975       +9     
+ Misses       1669     1663       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crsl4 crsl4 merged commit 787582f into JuliaPhylo:master Feb 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants