DO NOT MERGE: BREAKING: Completely remove the Slurm functionality from this package (and, in the README, point users to the SlurmClusterManager.jl package instead) #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
changed the title
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
3 times, most recently
from
6b1af89 to
cbeb2dc
Compare
DilumAluthge
force-pushed
the
dpa/breaking-remove-slurm
branch
from
577ee74 to
1b03cb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 25.40% 0.47% -24.94%
==========================================
Files 6 5 -1
Lines 307 211 -96
==========================================
- Hits 78 1 -77
+ Misses 229 210 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
cbeb2dc to
b35ad48
Compare
DilumAluthge
force-pushed
the
dpa/breaking-remove-slurm
branch
from
1b03cb5 to
8d5bd9b
Compare
Base automatically changed from
dpa/deprecate-but-do-not-remove-slurm-in-this-package
to
master
February 15, 2025 16:47
DilumAluthge
force-pushed
the
dpa/breaking-remove-slurm
branch
from
8d5bd9b to
f12df32
Compare
… (and, in the README, point users to the SlurmClusterManager.jl package instead)
DilumAluthge
force-pushed
the
dpa/breaking-remove-slurm
branch
from
0a9ade9 to
295aba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260
Depends on: