Update Gumbo version to 0.13.2 and adjust build sources #12015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Sep 5, 2025
| @@ -3,22 +3,37 @@ | |||
| using BinaryBuilder | |||
|
|
|||
| name = "Gumbo" | |||
| version = v"0.10.2" # <-- This version number is a lie to build for experimental platforms | |||
| version = v"0.13.2" # <-- This version number is a lie to build for experimental platforms | |||
There was a problem hiding this comment.
The comment doesn't seem to be accurate anymore?
Comment on lines
+14
to
+16
| # Vendor Autoconf 2.72 only to run autoreconf | ||
| ArchiveSource("https://mirrors.kernel.org/gnu/autoconf/autoconf-2.72.tar.xz", | ||
| "ba885c1319578d6c94d46e9b0dceb4014caafe2490e437a0dbca3f270a223f5a"), |
There was a problem hiding this comment.
Is 2.71 recent enough? We have it already as autoconf_jll, and you can use it as a host build dependency. And if you want 2.72 specifically you can update it at https://github.com/JuliaPackaging/Yggdrasil/blob/7014250f3801bb05118c940d869a826aaba0bc6b/A/autoconf/build_tarballs.jl.
There was a problem hiding this comment.
Yes, 2.72 is needed.
I'll do a PR for 2.72 here then: https://github.com/JuliaPackaging/Yggdrasil/blob/7014250f3801bb05118c940d869a826aaba0bc6b/A/autoconf/build_tarballs.jl.
Thank you.
| @@ -37,4 +52,4 @@ dependencies = Dependency[ | |||
| ] | |||
|
|
|||
| # Build the tarballs, and possibly a `build.jl` as well. | |||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6") | |||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6") | |||
There was a problem hiding this comment.
Please keep the trailing newline at the end of the file
Suggested change
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6") | |
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; julia_compat="1.6") | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the original repository was archived, its development was took up here: https://codeberg.org/gumbo-parser/gumbo-parser
There is already a pull request on the
Gumbo.jlin this sense: JuliaWeb/Gumbo.jl#103The current PR adjusted the source target of the repository and performed small dependency adjustment (Autoconf ≥2.72) to satisfy the upstream build.