Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_overflow for add, sub, and mul #102

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

mbarbar
Copy link
Contributor

@mbarbar mbarbar commented Jan 16, 2025

Mostly pulled from checked_x which are then made to use these. The tests are copies of the existing tests for checked_x with the addition of a few tests exercising non-overflowing cases.

@mbarbar mbarbar changed the title Add with_overflow for add, subtract, and mul Add with_overflow for add, sub, and mul Jan 16, 2025
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! :) Thanks @mbarbar! LGTM

@NHDaly NHDaly merged commit 6c6df97 into JuliaMath:master Jan 16, 2025
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants