Clean up ButterflyFactorization #103
Conversation
src/butterflylu.jl
Outdated
| C | ||
| end | ||
|
|
||
| function 🦋2!(C, A::Diagonal, B::Diagonal) |
There was a problem hiding this comment.
What's the difference between 🦋2! and 🦋!? Can we unify them?
There was a problem hiding this comment.
yeah this was one thing I wanted to talk about, currently we have two functions because 🦋! can't accept submatrices generated by view calls, so as of right now we need the second 🦋2! function for those cases, but ideally we would combine those.
There was a problem hiding this comment.
I think the answer here might be the same as to the issue with 🦋! allocating, in that it might be worth allocating a butterfly matrix with the proper diagonals preallocated and fill in the entries manually.
There was a problem hiding this comment.
But this wouldn't allow us to pass submatrices into the function right? so we would still need 🦋2!?
There was a problem hiding this comment.
it could just be a separate method of 🦋!.
| end | ||
|
|
||
| function 🦋!(C::SparseBandedMatrix, A::Diagonal, B::Diagonal) | ||
| setdiagonal!(C, [A.diag; -B.diag], true) |
There was a problem hiding this comment.
[A.diag; -B.diag] allocates. Any way to avoid?
There was a problem hiding this comment.
hmm not sure to be honest
src/butterflylu.jl
Outdated
| M = size(U, 1) | ||
| Mh = M >>> 1 |
|
@ChrisRackauckas I think this is good to go |
No description provided.