-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Tweaks to results.json
#57686
base: master
Are you sure you want to change the base?
CI: Tweaks to results.json
#57686
Conversation
95328b4
to
96ec737
Compare
600fb89
to
e5cabc0
Compare
e5cabc0
to
149657f
Compare
Can you expand on this a little bit? |
Currently we report that a test takes the duration of its parent testset. So |
Oh yeah, that's silly. Can we capture useful duration times? |
Our |
148a1c6
to
780ba21
Compare
780ba21
to
155941f
Compare
Todo:
Identified: If a test like
@test x == y
passes, thePass
object retainsx
. I changed the weakref test to not do this by testing the outer function, as I don't think it's what that test is actually testing. But the question remains about whether this is unexpected behavior. Might alone be grounds for more eagerly streaming results to file so we can free the referenced values.stdlib
etc prefix to path to make repo links work