Skip to content

Commit

Permalink
warn if General is installed via the old slow methods
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth committed Sep 18, 2024
1 parent e5f400b commit 8d702cf
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/Registry/Registry.jl
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,12 @@ function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true,
registry_update_log[string(reg.uuid)] = now()
@label done_tarball_read
else
@info """
The General registry is installed via unpacked tarball.
Consider reinstalling it via the newer faster direct from
tarball format by running:
pkg> registry rm General; registry add General
""" maxlog=1
mktempdir() do tmp
try
download_verify_unpack(url, nothing, tmp, ignore_existence = true, io=io)
Expand All @@ -465,6 +471,13 @@ function update(regs::Vector{RegistrySpec}; io::IO=stderr_f(), force::Bool=true,
end
elseif isdir(joinpath(reg.path, ".git"))
printpkgstyle(io, :Updating, "registry at " * regpath)
if reg.name == "General"
@info """
The General registry is installed via git. Consider reinstalling it via
the newer faster direct from tarball format by running:
pkg> registry rm General; registry add General
""" maxlog=1
end
LibGit2.with(LibGit2.GitRepo(reg.path)) do repo
if LibGit2.isdirty(repo)
push!(errors, (regpath, "registry dirty"))
Expand Down

0 comments on commit 8d702cf

Please sign in to comment.