Skip to content

Test: prune old LA based on ENV variable #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented May 4, 2025

This PR prunes the old LinearAlgebra module based on an environment variable that is set in .ci/run_tests.jl. Hopefully, this would mean that tests that are being run without this environment variable would run as expected without precompilation issues.

The goal of this PR is to ensure that when julia is being built with the master branch of LinearAlgebra, the tests would work without the need for pruning (i.e., we want to fix the test failures in JuliaLang/julia#58242).

This would also mean that to run the tests locally, one would need to set the JULIA_PRUNE_OLD_LA environment variable to true.

Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (c9b6456) to head (04359c8).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1335   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          34       34           
  Lines       15752    15752           
=======================================
  Hits        14766    14766           
  Misses        986      986           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub marked this pull request as draft May 4, 2025 10:04
@jishnub jishnub changed the title Prune old LA based on ENV variable Test: prune old LA based on ENV variable May 4, 2025
@jishnub jishnub added the test This change adds or pertains to unit tests label May 4, 2025
@jishnub jishnub requested a review from KristofferC May 4, 2025 15:55
@jishnub jishnub marked this pull request as ready for review May 4, 2025 16:17
@KristofferC
Copy link
Member

I thought about disabling this only when we run on Julia buildkite so that includeing a test file would still work. But I am not sure if there is a good env variable to look at there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants