incremental option to parse!() + callable Expr compat code
#598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I've made two changes to make JuliaSyntax easier to integrate into Base without requiring the existing hook mechanism. The `incremental` option has been added to `parse!()` moving flisp-compatible whitespace handling (eg, parsing a statement consumes up to the next newline) out of the hook and into the main `parse!()` API function. The logic for constructing `Expr(:incomplete)` and appropriate `Expr(:error)` for flisp compatibility is now callable separately from the hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've made two changes to make JuliaSyntax easier to integrate into Base without requiring the existing hook mechanism.
The
incrementaloption has been added toparse!()moving flisp-compatible whitespace handling (eg, parsing a statement consumes up to the next newline) out of the hook and into the mainparse!()API function.The logic for constructing
Expr(:incomplete)and appropriateExpr(:error)for flisp compatibility is now callable separately from the hook.