Add RemoteLogger #94
Open
Add RemoteLogger #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theogf
commented
Mar 27, 2024
| function Logging.handle_message(logger::RemoteLogger, level::Logging.LogLevel, message, _module, _group, _id, | ||
| _file, _line; kwargs...) | ||
| @nospecialize | ||
| remote_do(logmsg, logger.pid, level, message, _module, _group, _id, _file, _line; pid=myid(), kwargs...) |
There was a problem hiding this comment.
Here I thought we could directly use handle_message from the targetted worker but I don't know how to fetch the current_logger there...
fatteneder
reviewed
Jul 18, 2024
You could acknowledge @simonbyrne by adding a line to a commit message. |
Co-authored-by: simonbyrne <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 79.14% 79.23% +0.08%
==========================================
Files 10 11 +1
Lines 1899 1907 +8
==========================================
+ Hits 1503 1511 +8
Misses 396 396 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52
This is the port from JuliaLang/julia#48121 by @simonbyrne .
I mostly reused the code from the PR, if that's not okay let me know I'll just close this PR.
I also did not made the modification on using this as a default for new workers as this would be unexpected behaviour.