-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump LLVM and GPUCompiler versions + related fixes #82
Open
gbaraldi
wants to merge
6
commits into
main
Choose a base branch
from
gb/misc-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop abi_call for a plain invoke call Change to use string api for pass manager Drop support for versions before 1.10
topolarity
reviewed
Sep 18, 2024
@@ -93,12 +93,28 @@ Find all static allocation sites in the provided LLVM IR. | |||
|
|||
This function modifies the LLVM module in-place, effectively trashing it. | |||
""" | |||
function find_allocs!(mod::LLVM.Module, meta; ignore_throw=true) | |||
function find_allocs!(mod::LLVM.Module, meta, entry_name::String; ignore_throw=true, invoke_entry=false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document what invoke_entry
does?
Looking pretty good, but I'd like to ideally get nightly working: [91723] signal 11 (1): Segmentation fault
in expression starting at /home/topolarity/repos/AllocCheck/test/runtests.jl:181
_ZNK4llvm11LLVMContext14getOptPassGateEv at /home/topolarity/repos/julia/usr/bin/../lib/libLLVM.so.18.1jl (unknown line)
unknown function (ip: (nil))
Allocations: 24540140 (Pool: 24539670; Big: 470); GC: 18
ERROR: Package AllocCheck errored during testing (received signal: 11) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes entail
Drop abi_call for a plain invoke call
Change to use string api for pass manager
Drop support for versions before 1.10
1.11 still segfaults so I'm taking a further look1.11 passes tests