Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for julia 0.5 #20

Merged
merged 2 commits into from
Oct 18, 2016
Merged

update for julia 0.5 #20

merged 2 commits into from
Oct 18, 2016

Conversation

CarloLucibello
Copy link
Member

put a checkout for LG in travis just to check if everything is alright

@CarloLucibello CarloLucibello changed the title [DO NOT MERGE[ update REQUIRE and travis (TEMPORARY FIX) [DO NOT MERGE] update require and travis (TEMPORARY FIX) Sep 22, 2016
@codecov-io
Copy link

codecov-io commented Sep 22, 2016

Current coverage is 100% (diff: 100%)

Merging #20 into master will not change coverage

@@           master   #20   diff @@
===================================
  Files          14    13     -1   
  Lines         207   210     +3   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits          207   210     +3   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 73c2f7a...40aec71

@CarloLucibello CarloLucibello force-pushed the 0.5-update branch 3 times, most recently from 5336449 to c8717c4 Compare September 23, 2016 07:25
@CarloLucibello CarloLucibello changed the title [DO NOT MERGE] update require and travis (TEMPORARY FIX) update for julia 0.5 Sep 29, 2016
@CarloLucibello
Copy link
Member Author

CarloLucibello commented Sep 29, 2016

I removed the combinatorial_adjacency function and GraphMatrices dependence, since they will be part of LG

this should ready to merge, and after that we can finally tag a 0.5 compatible version

@sbromberger
Copy link
Contributor

We need to wait until sbromberger/LightGraphs.jl#472 and sbromberger/LightGraphs.jl#473 are merged before we do this - otherwise I think we're going to lose functionality in the interim.

@CarloLucibello
Copy link
Member Author

well, right now 0.5 users have no functionality at all, they can't install the package...

julia 0.4 0.5-
LightGraphs
julia 0.5-
LightGraphs 0.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this to 0.7.2 please?

@sbromberger
Copy link
Contributor

@CarloLucibello I'm ready to ignore the nightly failure if you think this is ready to go.

@CarloLucibello
Copy link
Member Author

go!

@sbromberger sbromberger merged commit 9190a75 into master Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants