-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests to api validation testing #447
Conversation
Right this is still broken on Ventura. I'll split up the PR into what will pass CI now and what can wait. |
04e9f85
to
bdb9ef0
Compare
bdb9ef0
to
ffc6265
Compare
All tests can now be run with the shader validation enabled except for |
At some point we should device and audit whether to check for non-zero length as part of each API call (e.g., Lines 534 to 540 in 711758d
|
That's from a recent PR where I tried to address some validation errors. I can remove the high-level change since it wasn't enough and leave the low-level one in #464 |
Not worth running a test we know will fail with only one apple silicon runner.