Skip to content

lmul/rmul support for Diagonals #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshyatt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lmul/rmul support for Diagonals #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5940765
lmul/rmul support for Diagonals
kshyatt Dec 23, 2025
22c437d
Less stupid way
kshyatt Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/host/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,7 @@ function generic_rmul!(X::AbstractArray, s::Number)
end

LinearAlgebra.rmul!(A::AbstractGPUArray, b::Number) = generic_rmul!(A, b)
LinearAlgebra.rmul!(A::Diagonal{T, <:AbstractGPUArray}, b::Number) where {T} = generic_rmul!(A.diag, b)

function generic_lmul!(s::Number, X::AbstractArray)
@kernel function lmul_kernel!(X, s)
Expand All @@ -694,6 +695,7 @@ function generic_lmul!(s::Number, X::AbstractArray)
end

LinearAlgebra.lmul!(a::Number, B::AbstractGPUArray) = generic_lmul!(a, B)
LinearAlgebra.lmul!(a::Number, B::Diagonal{T, <:AbstractGPUArray}) where {T} = generic_lmul!(a, B.diag)


## permutedims
Expand Down
15 changes: 15 additions & 0 deletions test/testsuite/linalg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,21 @@ end
A_empty = randn(Float32, 0, 0)
@test compare(f, AT, A_empty, d)
end

@testset "rmul!/lmul! with diagonal and number" begin
n = 32
h_d = rand(Float32, n)
h_D = Diagonal(h_d)
d = AT(h_d)
D = Diagonal(d)
a = rand(Float32)
rmul!(D, a)
rmul!(h_D, a)
@test collect(D) ≈ h_D
lmul!(a, D)
lmul!(a, h_D)
@test collect(D) ≈ h_D
end
end

@testsuite "linalg/mul!/vector-matrix" (AT, eltypes)->begin
Expand Down
Loading