-
Notifications
You must be signed in to change notification settings - Fork 154
Add public
declarations
#744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 89.57% 86.96% -2.62%
==========================================
Files 11 10 -1
Lines 969 959 -10
==========================================
- Hits 868 834 -34
- Misses 101 125 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a very welcome initiative to guarantee API stability! So many people have been using ForwardDiff internals that they're not really internals anymore at this point. |
Gentle bump on this one |
eval(Meta.parse( | ||
"public derivative, derivative!, gradient, gradient!, jacobian, jacobian!, | ||
hessian, hessian!, DerivativeConfig, GradientConfig, JacobianConfig, HessianConfig")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bit more direct:
eval(Meta.parse( | |
"public derivative, derivative!, gradient, gradient!, jacobian, jacobian!, | |
hessian, hessian!, DerivativeConfig, GradientConfig, JacobianConfig, HessianConfig")) | |
eval(Expr( | |
:public, | |
:derivative, | |
:derivative!, | |
:gradient, | |
:gradient!, | |
:jacobian, | |
:jacobian!, | |
:hessian, | |
:hessian!, | |
:DerivativeConfig, | |
:GradientConfig, | |
:JacobianConfig, | |
:HessianConfig)) |
First commit adds only those in
api.md
, but perhaps we should add more... likeDual
?(
eval
is following this https://github.com/JuliaLang/julia/pull/55097/files )