Skip to content

Conversation

@MasonProtter
Copy link
Contributor

Attempt at alternative to JuliaDiff/ChainRulesCore.jl#653 for fixing #769

@MasonProtter MasonProtter changed the title Try deleting the one(::Any) and zero(::Any) non_diff methods Try deleting the one(::Any) and zero(::Any) non_diff methods Jan 19, 2024
@oxinabox
Copy link
Member

oxinabox commented Jan 23, 2024

Yes, this seems to fix the problem in Diffractor and these methods are kinda wrong anyway,
since we do need to have a zero value here, the tanget space does (in general) exist.
This matters for forward mutation support in Diffractor where NoTangent() gets left as is, but ZeroTangent gets made into a a concrete zero value if it is mutable.

(zeros is also wrong, I'll make another PR for that)

Fixes #769

@oxinabox
Copy link
Member

Remaining CI issues are unrelated so merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants