Skip to content

Script to ping ControlExamplePlots #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 31, 2020
Merged

Script to ping ControlExamplePlots #277

merged 14 commits into from
Mar 31, 2020

Conversation

mfalt
Copy link
Member

@mfalt mfalt commented Mar 29, 2020

Pings ControlExamplePlots.jl so it can comment on PRs and show differences in plots, see JuliaControl/ControlExamplePlots.jl#2

(This is a copy of #275 since we need the PR to come from inside the org to test it)

@coveralls
Copy link

coveralls commented Mar 29, 2020

Coverage Status

Coverage remained the same at 57.76% when pulling af01828 on mfalt-patch-2 into 5dd627b on master.

@baggepinnen
Copy link
Member

looks pretty good :)

@mfalt
Copy link
Member Author

mfalt commented Mar 30, 2020

Testing new formatting

@mfalt mfalt closed this Mar 30, 2020
@mfalt mfalt reopened this Mar 30, 2020
@JuliaControlBot
Copy link

Something failed when generating plots. See the log at https://github.com/JuliaControl/ControlExamplePlots.jl/actions for more details.

@mfalt mfalt closed this Mar 30, 2020
@mfalt mfalt reopened this Mar 30, 2020
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references, see results below.

Difference Reference Image New Image
❌ 0.049 Reference New
❌ 0.038 Reference New
⚠️ 0.02 Reference New
⚠️ 0.029 Reference New
❌ 0.033 Reference New
❌ 0.031 Reference New
❌ 0.031 Reference New
❌ 0.042 Reference New
❌ 0.051 Reference New
✔️ 0.014 Reference New
⚠️ 0.019 Reference New

@JuliaControl JuliaControl deleted a comment from JuliaControlBot Mar 30, 2020
@mfalt
Copy link
Member Author

mfalt commented Mar 31, 2020

I don't see any harm in pulling this now, feel free to do it if you agree @baggepinnen

@baggepinnen baggepinnen merged commit 4f333ac into master Mar 31, 2020
@baggepinnen baggepinnen deleted the mfalt-patch-2 branch March 31, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants