Fix fence elision on Julia 1.10 and 1.11 - #23
Merged
Merged
Conversation
JuliaLang/julia#57806 corrected the effect modeling for atomic_fence in Julia 1.12. On 1.10 and 1.11, a fence inlined through UnsafeAtomics.fence can be deleted when its unused result is dropped, even though a direct intrinsic call survives. Lower system-scope fences through llvmcall on affected versions, preserving the weaker-ordering no-ops and x86-64 seq_cst special case. Test that optimized code retains each supported fence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#57806 corrected the effect modeling for atomic_fence in Julia 1.12. On 1.10 and 1.11, a fence inlined through UnsafeAtomics.fence can be deleted when its unused result is dropped, even though a direct intrinsic call survives.
Lower system-scope fences through llvmcall on affected versions, preserving the weaker-ordering no-ops and x86-64 seq_cst special case. Test that optimized code retains each supported fence.