Add ChainRules Overloads to StaticArrays #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems there is an older PR #1068 I have moved the dependency into a weakdep and added more minimal tests based on the discussion there. Let me know what else needs to be done. |
avik-pal
force-pushed
the
ap/chainrules
branch
2 times, most recently
from
23e1e1e to
3ebb07c
Compare
avik-pal
force-pushed
the
ap/chainrules
branch
from
3ebb07c to
f5aef04
Compare
This was referenced Dec 10, 2023
Member
|
Given the discussion in #1068 and JuliaDiff/ChainRules.jl#761, this is the proper place for it to live. The only issue people brought up in #1068 was the dependency size, which is addressed by this PR using package extensions, so it looks good to go. |
ChrisRackauckas
approved these changes
Dec 14, 2023
Member
|
If someone wants to add this to our Downstream tests in ChainRulesCore CI we can make sure not to accidentally break it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules were a part of SciMLSensitivity https://github.com/SciML/SciMLSensitivity.jl/blob/f1aa09244e45598874e1a14a008356a2b2b241a1/src/staticarrays.jl#L23
I will add some tests. But any objections to moving them here?
cc @ChrisRackauckas