- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6
Add FixedSizeBitArray #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            oscardssmith
  wants to merge
  3
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
os/FixedSizeBitArray
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    nsajko
  
              
              reviewed
              
                  
                    Jan 4, 2025 
                  
              
              
            
            
              
                    nsajko
  
              
              reviewed
              
                  
                    Jan 4, 2025 
                  
              
              
            
            
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
- Coverage   98.71%   82.73%   -15.98%     
===========================================
  Files           3        4        +1     
  Lines         233      278       +45     
===========================================
  Hits          230      230               
- Misses          3       48       +45     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| 
 Why not split it up? | 
| I probably will | 
c2db992    to
    7c49043      
    Compare
  
    | Some tests would be good now 🙂 | 
7c49043    to
    e00a970      
    Compare
  
    | Closes #155 | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This arguably should be 2 separate PRs, the first splits the code in this repo into files for better separation of concerns, while the 2nd (and only functional change) adds a new
FixedSizeBitArraythat is similar to a regularBitArray, but is fixed size, and makes sure that columns don't alias each-other (by giving each column it's own chunk). This slightly complicates indexing, but it makes lots of matrix operations a lot faster since you can broadcast views of the columns with each-other without worrying about columns clobbering each other.