Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Re-enable axis checks in constructor #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: Re-enable axis checks in constructor #91

wants to merge 1 commit into from

Commits on Jun 11, 2017

  1. RFC: Re-enable axis checks in constructor 

    This is a major breaking change. Back before this package was officially registered, these checks were dropped. That means that many of the indexing methods that require sorted vectors are now broken. Enforcing these preconditions in the constructor is, unfortunately, terribly breaking.

I think the alternative here would be to delay the checks until indexing occurs, but the downside there is that for non-range axes, it would require a `issorted` pass through the data upon every operation. We could defer to the SortedVector type more, but that easily walks us into a type-unstable API. Thoughts?
    @mbauman
    mbauman committed Jun 11, 2017
    Configuration menu
    Copy the full SHA
    891a608 View commit details
    Browse the repository at this point in the history