Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow color interpolation in change #390

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Conversation

Wikunia
Copy link
Member

@Wikunia Wikunia commented Aug 11, 2021

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Partially closes #363

How did you address these issues with this PR? What methods did you use?
I've changed the standard interpolation in the change function to use Animations.jl now.
That means we interpolate a single time to get the t value using Animations.jl which is based on the easing function but then also use Animations.jl to interpolate using the t value the actual value that we want to change.

Additionally I saw that JBox only allows strings as colors which shouldn't be the case so I fixed that as well.

@Wikunia Wikunia requested a review from TheCedarPrince August 11, 2021 15:50
@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #390 (bcf39b2) into master (0a4f3e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head bcf39b2 differs from pull request most recent head 3021b11. Consider uploading reports for the commit 3021b11 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   96.24%   96.25%           
=======================================
  Files          35       35           
  Lines        1519     1521    +2     
=======================================
+ Hits         1462     1464    +2     
  Misses         57       57           
Impacted Files Coverage Δ
src/shorthands/JBox.jl 100.00% <ø> (ø)
src/action_animations.jl 100.00% <100.00%> (ø)
src/util.jl 97.08% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4f3e0...3021b11. Read the comment docs.

@Wikunia Wikunia mentioned this pull request Aug 11, 2021
Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I like the syntax that we now have with this. Feel free to merge.

I wonder if we should add this to a tutorial somewhere. I could see redoing Tutorial 7 with J-Objects and this syntax in mind. But that is another issue. :)

Merge it!

Copy link
Member

@TheCedarPrince TheCedarPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually, can you go ahead and use this PR to bump the release version? That way we can have this released and close another issue or two.

@TheCedarPrince TheCedarPrince merged commit 3ae40fb into master Aug 13, 2021
@TheCedarPrince TheCedarPrince deleted the wik-feature-color-change branch August 13, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animate change of color
2 participants