-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow color interpolation in change #390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
=======================================
Coverage 96.24% 96.25%
=======================================
Files 35 35
Lines 1519 1521 +2
=======================================
+ Hits 1462 1464 +2
Misses 57 57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I like the syntax that we now have with this. Feel free to merge.
I wonder if we should add this to a tutorial somewhere. I could see redoing Tutorial 7 with J-Objects and this syntax in mind. But that is another issue. :)
Merge it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, can you go ahead and use this PR to bump the release version? That way we can have this released and close another issue or two.
PR Checklist
If you are contributing to
Javis.jl
, please make sure you are able to check off each item on this list:CHANGELOG.md
with whatever changes/features I added with this PR?Project.toml
+ set an upper bound of the dependency (if applicable)?test
directory (if applicable)?Link to relevant issue(s)
Partially closes #363
How did you address these issues with this PR? What methods did you use?
I've changed the standard interpolation in the
change
function to use Animations.jl now.That means we interpolate a single time to get the
t
value using Animations.jl which is based on the easing function but then also use Animations.jl to interpolate using thet
value the actual value that we want to change.Additionally I saw that
JBox
only allows strings as colors which shouldn't be the case so I fixed that as well.