Skip to content

[feat/#432] 이미지 없을 시 null이 아닌 빈배열 return #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PicturePark1101 merged 3 commits into from
Jul 8, 2025
Merged

[feat/#432] 이미지 없을 시 null이 아닌 빈배열 return #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
238fe34
feat : 이미지 없을 시 null이 아닌 빈배열 return #432
PicturePark1101 Jul 8, 2025
7d5f91d
feat : dev 가입시에도 디스코드 알림 가도록 고침 #432
PicturePark1101 Jul 8, 2025
37e3d30
refactor : 불필요한 import 제거 #432
PicturePark1101 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/umc/th/juinjang/api/note/shared/service/response/SharedNoteGetResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@ private static List<String> findImagesUrlBySharingStatus(boolean isImageShared,
if (isImageShared) {
return limjang.getImageList().stream().map(Image::getImageUrl).limit(maxSize).toList();
}
return null;
return List.of();
}
}
22 changes: 7 additions & 15 deletions src/main/java/umc/th/juinjang/event/subscriber/DiscordEventListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import lombok.RequiredArgsConstructor;

import org.springframework.core.env.Environment;
import org.springframework.core.env.Profiles;
import org.springframework.scheduling.annotation.Async;
import org.springframework.stereotype.Component;
import org.springframework.transaction.event.TransactionPhase;
Expand All @@ -19,16 +17,13 @@
public class DiscordEventListener {

private final DiscordAlertProvider discordAlertProvider;
private final Environment environment;

@TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT)
@Async
public void handleSignUpEvent(SignUpEvent event) {
if (isProdEnv()) {
discordAlertProvider.sendMemberCreateAlertToDiscord(
String.format(EventMessage.SIGN_UP_MESSAGE.getMessage(), event.memberProvider(), event.count(),
event.name()));
}
discordAlertProvider.sendMemberCreateAlertToDiscord(
String.format(EventMessage.SIGN_UP_MESSAGE.getMessage(), event.memberProvider(), event.count(),
event.name()));
}

@TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT)
Expand All @@ -46,13 +41,10 @@ public void handleFlagSharedNoteEvent(FlagSharedNoteEvent event) {
@TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT)
@Async
public void handlePaymentEvent(PaymentEvent event) {
discordAlertProvider.sendPaymentAlertToDiscord(String.format(
EventMessage.PAYMENT_COMPLETED_MESSAGE.getMessage(),
event.memberId(),event.nickname(),event.pencilQuantity(), event.price(), event.transactionStatus()
));
discordAlertProvider.sendPaymentAlertToDiscord(String.format(
EventMessage.PAYMENT_COMPLETED_MESSAGE.getMessage(),
event.memberId(), event.nickname(), event.pencilQuantity(), event.price(), event.transactionStatus()
));
}

private boolean isProdEnv() {
return environment.acceptsProfiles(Profiles.of("prod"));
}
}