-
Notifications
You must be signed in to change notification settings - Fork 2
[feat/#310] 멤버에 한 줄 소개 및 연필 추가 #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/umc/th/juinjang/domain/member/model/Member.java # src/main/java/umc/th/juinjang/domain/pencilaccount/model/PencilAccount.java
- Controller 테스트를 위해서, 메인 어플리케이션에서 configuration 으로 분리
- 서비스 테스트 코드 구현
Contributor
|
테스트코드 잘 보았습니다 아직 테스트 코드 짜본 적 없는데 저도 API 구현 후 한번 시도해보고 싶어요!! 고생많으셨습니다!! 👍 👍 |
PicturePark1101
approved these changes
Apr 5, 2025
hyeonahhh
reviewed
Apr 6, 2025
| import umc.th.juinjang.api.pencilAccount.service.PencilAccountService; | ||
| import umc.th.juinjang.domain.member.model.Member; | ||
|
|
||
| @WebMvcTest(PencilAccountController.class) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
컨트롤러 테스트는 실제로 처음 보는데 너무 대단하신 것 같아요..! 오늘도 한수 배웁니다.. 고생하셨습니다~!!
PicturePark1101
pushed a commit
that referenced
this pull request
Jun 1, 2025
[feat/#310] 멤버에 한 줄 소개 및 연필 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
추가로 설정할 내용
상세설명_ & 캡쳐
pencilAccount 에 Cascade.All 를 추가하여, 회원가입 시에, 연필 계좌도 자동적으로 생성하도록 수정
컨트롤러 테스트를 위해서, 메인어플리케이션에서 @EnableJpaAuditing 을 Configuration 클래스로 변경
컨트롤러 테스트