Skip to content

Ckeditor 47 + Table support#4935

Open
traumschule wants to merge 56 commits intoJoystream:devfrom
traumschule:ckeditor-47
Open

Ckeditor 47 + Table support#4935
traumschule wants to merge 56 commits intoJoystream:devfrom
traumschule:ckeditor-47

Conversation

@traumschule
Copy link
Copy Markdown
Collaborator

#4032

Upgrade CkEditor

We were using "@ckeditor/ckeditor5-table": "31.0.0" and should update-to-47
packages/markdown-editor/MarkdownEditor.js:

import Table from '@ckeditor/ckeditor5-table/src/table'

Changes

old

packages/markdown-editor/webpack.config.js:const CKEditorWebpackPlugin = require('@ckeditor/ckeditor5-dev-webpack-plugin')

new

const { CKEditorTranslationsPlugin } = require( '@ckeditor/ckeditor5-dev-translations' );

// Define webpack plugins ...
	plugins: [
		new CKEditorTranslationsPlugin( options ),

Fix table preview

  • Generate unquoted html

Leszek Wiesner and others added 30 commits April 2, 2025 11:59
* Replace Subscan with Statescan (Joystream#4867)

* Replace Subscan with Statescan

* Fix formatting

* Fix failing playwright install in CI checks

* Bump version to 3.7.3

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Replace Subscan with Statescan (Joystream#4867)

* Replace Subscan with Statescan

* Fix formatting

* Fix failing playwright install in CI checks

* Council and election pages: Small enhancements - Issue 4866 (Joystream#4869)

* react snap setup

* react snap setup

* react snap setup

* seo

* council and past council page

* Add term start and end (estimated) dates for current term

* total number of votes & total voting stake during Voting and Revealing period

* Add Election Result and Revealed votes statistics

* added past councils route and candidate vote highlight

* latest election fields update

* undo react-snap

* removed uneccesary package update

* removed uneccesary package update

* chore: remove yarn.lock from tracked files

* git error fix

* chore: revert yarn.lock to match main

* removed eslint comment

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Apply suggestions from code review

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/index.html

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/council/components/pastCouncil/PastCouncilsList/PastCouncilListItem.tsx

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* estimated ends at

* council id

* rearranged mock

* review changes

* review changes

* test error fix

---------

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Bump version, update CHANGELOG

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
Co-authored-by: Victor Emmanuel <33874323+vrrayz@users.noreply.github.com>
* Replace Subscan with Statescan (Joystream#4867)

* Replace Subscan with Statescan

* Fix formatting

* Fix failing playwright install in CI checks

* Bump version to 3.7.3

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
* Replace Subscan with Statescan (Joystream#4867)

* Replace Subscan with Statescan

* Fix formatting

* Fix failing playwright install in CI checks

* Council and election pages: Small enhancements - Issue 4866 (Joystream#4869)

* react snap setup

* react snap setup

* react snap setup

* seo

* council and past council page

* Add term start and end (estimated) dates for current term

* total number of votes & total voting stake during Voting and Revealing period

* Add Election Result and Revealed votes statistics

* added past councils route and candidate vote highlight

* latest election fields update

* undo react-snap

* removed uneccesary package update

* removed uneccesary package update

* chore: remove yarn.lock from tracked files

* git error fix

* chore: revert yarn.lock to match main

* removed eslint comment

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Apply suggestions from code review

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/index.html

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/council/components/pastCouncil/PastCouncilsList/PastCouncilListItem.tsx

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Update packages/ui/src/council/components/election/pastElection/PastElectionStats.tsx

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* estimated ends at

* council id

* rearranged mock

* review changes

* review changes

* test error fix

---------

Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>

* Bump version, update CHANGELOG

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
Co-authored-by: Victor Emmanuel <33874323+vrrayz@users.noreply.github.com>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
Co-authored-by: Oleksandr Korniienko <oleksanderkorn@gmail.com>
Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
traumschule and others added 25 commits December 2, 2025 09:26
commit bff32eb
Author: l1.media <dev@l1.media>
Date:   Sun Nov 23 14:09:26 2025 +0000

    don't batch

commit f78d34d
Author: l1.media <dev@l1.media>
Date:   Sun Nov 23 13:12:39 2025 +0000

    use root account to change controller
Co-authored-by: goldstarhigher <heinrich.olf@gmail.com>
Co-authored-by: eshark9312 <eshark9312@outlook.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
dao Ready Ready Preview Dec 3, 2025 7:20pm
pioneer-2 Ready Ready Preview Dec 3, 2025 7:20pm
pioneer-2-storybook Error Error Dec 3, 2025 7:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants