Rename found to foundNumberEnd in number parsing logic
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JoshdRod <[email protected]>
Copilot
AI
changed the title
[WIP] Update input expressions binary tree implementation
Rename Dec 27, 2025
found to foundNumberEnd in number parsing logic
Owner
|
LGTM |
JoshdRod
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #8 to improve variable naming clarity in the expression parser.
Changes
found→foundNumberEndin the number parsing section ofexpressionToComponentList()to better indicate the variable tracks whether the end of a number token has been locatedThe variable is used in three locations (lines 182, 191, 195) within the number parsing block that scans ahead to find where numeric sequences terminate.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.