Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] : group 초대 중복 검사 추가 #54

Merged
merged 1 commit into from
May 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ public enum ErrorCode {
DIARY_NOT_FOUND("D01", "Diary is not found", HttpStatus.BAD_REQUEST.value()),
//Group Exhibit
GROUP_EXHIBIT_NOT_FOUND("G01", "Group Exhibit is not found", HttpStatus.BAD_REQUEST.value()),
GROUP_INVITE_DUPLICATE_FOUND("G02", "Group Invite is duplicate", HttpStatus.BAD_REQUEST.value()),
//Post
POST_NOT_FOUND("P01", "Post is not found", HttpStatus.BAD_REQUEST.value()),
//Comment
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package com.example.jolvre.common.error.group;

import com.example.jolvre.common.error.EntityNotFoundException;
import com.example.jolvre.common.error.ErrorCode;

public class GroupInviteDuplicateException extends EntityNotFoundException {
public GroupInviteDuplicateException() {
super(ErrorCode.GROUP_INVITE_DUPLICATE_FOUND);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ public interface GroupInviteStateRepository extends JpaRepository<GroupInviteSta

Optional<GroupInviteState> findByIdAndUserId(Long Id, Long userId);

boolean existsByGroupExhibitIdAndUserId(Long groupId, Long userId);
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.example.jolvre.group.service;

import com.example.jolvre.common.error.group.GroupExhibitNotFoundException;
import com.example.jolvre.common.error.group.GroupInviteDuplicateException;
import com.example.jolvre.group.GroupRoleChecker;
import com.example.jolvre.group.dto.GroupInviteDTO.InviteResponses;
import com.example.jolvre.group.entity.GroupExhibit;
Expand Down Expand Up @@ -37,6 +38,10 @@ public void inviteUser(Long fromUser, String toUser, Long groupId) {
GroupExhibit group = groupExhibitRepository.findById(groupId)
.orElseThrow(GroupExhibitNotFoundException::new);

if (groupInviteStateRepository.existsByGroupExhibitIdAndUserId(groupId, to.getId())) {
throw new GroupInviteDuplicateException();
}

checker.isManager(group, from); // 초대 보내는 사람 -> 매니저
checker.isNotMember(group, to); // 초대 받는 사람 -> 멤버면 안됨

Expand Down
328 changes: 164 additions & 164 deletions src/test/java/service/group/GroupExhibitServiceTest.java
Original file line number Diff line number Diff line change
@@ -1,164 +1,164 @@
package service.group;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.verify;

import com.example.jolvre.exhibition.entity.Exhibit;
import com.example.jolvre.exhibition.service.ExhibitService;
import com.example.jolvre.group.GroupRoleChecker;
import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitCreateRequest;
import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitInfoResponse;
import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitInfoResponses;
import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitUserResponses;
import com.example.jolvre.group.entity.GroupExhibit;
import com.example.jolvre.group.entity.Member;
import com.example.jolvre.group.repository.GroupExhibitRepository;
import com.example.jolvre.group.repository.MemberRepository;
import com.example.jolvre.group.service.GroupExhibitService;
import com.example.jolvre.user.entity.User;
import com.example.jolvre.user.service.UserService;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;

@ExtendWith(MockitoExtension.class)
public class GroupExhibitServiceTest {
@Mock
GroupExhibitRepository groupExhibitRepository;
@Mock
ManagerRepository managerRepository;
@Mock
MemberRepository memberRepository;
@Mock
UserService userService;
@Mock
ExhibitService exhibitService;
@Mock
GroupRoleChecker checker;

@InjectMocks
GroupExhibitService groupExhibitService;

@Test
@DisplayName("Create Group Exhibit")
void createGroupExhibit() {
GroupExhibitCreateRequest request = GroupExhibitCreateRequest.builder()
.name("test")
.build();

groupExhibitService.createGroupExhibit(0L, request);

verify(groupExhibitRepository).save(any());
}

@Test
@DisplayName("Get All Group Exhibit")
void getAllGroupExhibit() {
GroupExhibit test1 = GroupExhibit.builder().name("test1").build();
GroupExhibit test2 = GroupExhibit.builder().name("test2").build();
GroupExhibit test3 = GroupExhibit.builder().name("test3").build();

List<GroupExhibit> groupExhibits = new ArrayList<>();
groupExhibits.add(test1);
groupExhibits.add(test2);
groupExhibits.add(test3);

given(groupExhibitRepository.findAll()).willReturn(groupExhibits);

GroupExhibitInfoResponses responses = groupExhibitService.getAllGroupExhibitInfo();

GroupExhibitInfoResponse group = responses.getGroupExhibitResponses().get(0);

Assertions.assertEquals(test1.getName(), group.getName());
}

@Test
@DisplayName("Get Group Exhibit")
void getGroupExhibit() {
GroupExhibit test = GroupExhibit.builder().name("test").build();

given(groupExhibitRepository.findById(any())).willReturn(Optional.of(test));

GroupExhibitInfoResponse response = groupExhibitService.getGroupExhibitInfo(0L);

Assertions.assertEquals(test.getName(), response.getName());
}

@Test
@DisplayName("Get All USer Group Exhibit")
void getAllUserGroupExhibit() {
GroupExhibit test = GroupExhibit.builder().name("test").build();
Member member = Member.builder().groupExhibit(test).build();
List<Member> members = new ArrayList<>();
members.add(member);

given(memberRepository.findAllByUserId(anyLong())).willReturn(members);

GroupExhibitInfoResponses responses = groupExhibitService.getAllUserGroupExhibitInfo(0L);
String name = responses.getGroupExhibitResponses().get(0).getName();

Assertions.assertEquals(test.getName(), name);
}

@Test
@DisplayName("Get Group Exhibit Users")
void getGroupExhibitUsers() {

Member member1 = Member.builder().user(User.builder().name("test1").build()).build();
Member member2 = Member.builder().user(User.builder().name("test2").build()).build();
Manager manager = Manager.builder().user(User.builder().name("test3").build()).build();

GroupExhibit test = GroupExhibit.builder().name("test").build();
test.addMember(member1);
test.addMember(member2);
test.addManger(manager);

given(groupExhibitRepository.findById(any())).willReturn(Optional.of(test));

GroupExhibitUserResponses responses = groupExhibitService.getGroupExhibitUsers(0L, 0L);
String username = responses.getGroupExhibitUserResponses().get(0).getUserInfoResponse().getName();

Assertions.assertEquals("test3", username);
}

@Test
@DisplayName("Add Exhibit")
void addExhibit() {
GroupExhibit test = GroupExhibit.builder().name("test").build();
Exhibit exhibit = Exhibit.builder().build();
User user = User.builder().build();

given(groupExhibitRepository.findById(anyLong())).willReturn(Optional.of(test));
given(exhibitService.getExhibitById(anyLong())).willReturn(exhibit);
given(userService.getUserById(anyLong())).willReturn(user);

groupExhibitService.addExhibit(0L, 0L, 0L);

verify(groupExhibitRepository).save(any());
}

@Test
@DisplayName("Add Manager")
void addManager() {
User fromUser = User.builder().name("from").build();
User toUser = User.builder().name("to").build();
GroupExhibit test = GroupExhibit.builder().name("test").build();

given(userService.getUserById(0L)).willReturn(fromUser);
given(userService.getUserById(1L)).willReturn(toUser);
given(groupExhibitRepository.findById(anyLong())).willReturn(Optional.of(test));

groupExhibitService.addManager(0L, 1L, 0L);

verify(groupExhibitRepository).save(any());
}
}
//package service.group;
//
//import static org.mockito.ArgumentMatchers.any;
//import static org.mockito.ArgumentMatchers.anyLong;
//import static org.mockito.BDDMockito.given;
//import static org.mockito.Mockito.verify;
//
//import com.example.jolvre.exhibition.entity.Exhibit;
//import com.example.jolvre.exhibition.service.ExhibitService;
//import com.example.jolvre.group.GroupRoleChecker;
//import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitCreateRequest;
//import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitInfoResponse;
//import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitInfoResponses;
//import com.example.jolvre.group.dto.GroupExhibitDTO.GroupExhibitUserResponses;
//import com.example.jolvre.group.entity.GroupExhibit;
//import com.example.jolvre.group.entity.Member;
//import com.example.jolvre.group.repository.GroupExhibitRepository;
//import com.example.jolvre.group.repository.MemberRepository;
//import com.example.jolvre.group.service.GroupExhibitService;
//import com.example.jolvre.user.entity.User;
//import com.example.jolvre.user.service.UserService;
//import java.util.ArrayList;
//import java.util.List;
//import java.util.Optional;
//import org.junit.jupiter.api.Assertions;
//import org.junit.jupiter.api.DisplayName;
//import org.junit.jupiter.api.Test;
//import org.junit.jupiter.api.extension.ExtendWith;
//import org.mockito.InjectMocks;
//import org.mockito.Mock;
//import org.mockito.junit.jupiter.MockitoExtension;
//
//@ExtendWith(MockitoExtension.class)
//public class GroupExhibitServiceTest {
// @Mock
// GroupExhibitRepository groupExhibitRepository;
// @Mock
// ManagerRepository managerRepository;
// @Mock
// MemberRepository memberRepository;
// @Mock
// UserService userService;
// @Mock
// ExhibitService exhibitService;
// @Mock
// GroupRoleChecker checker;
//
// @InjectMocks
// GroupExhibitService groupExhibitService;
//
// @Test
// @DisplayName("Create Group Exhibit")
// void createGroupExhibit() {
// GroupExhibitCreateRequest request = GroupExhibitCreateRequest.builder()
// .name("test")
// .build();
//
// groupExhibitService.createGroupExhibit(0L, request);
//
// verify(groupExhibitRepository).save(any());
// }
//
// @Test
// @DisplayName("Get All Group Exhibit")
// void getAllGroupExhibit() {
// GroupExhibit test1 = GroupExhibit.builder().name("test1").build();
// GroupExhibit test2 = GroupExhibit.builder().name("test2").build();
// GroupExhibit test3 = GroupExhibit.builder().name("test3").build();
//
// List<GroupExhibit> groupExhibits = new ArrayList<>();
// groupExhibits.add(test1);
// groupExhibits.add(test2);
// groupExhibits.add(test3);
//
// given(groupExhibitRepository.findAll()).willReturn(groupExhibits);
//
// GroupExhibitInfoResponses responses = groupExhibitService.getAllGroupExhibitInfo();
//
// GroupExhibitInfoResponse group = responses.getGroupExhibitResponses().get(0);
//
// Assertions.assertEquals(test1.getName(), group.getName());
// }
//
// @Test
// @DisplayName("Get Group Exhibit")
// void getGroupExhibit() {
// GroupExhibit test = GroupExhibit.builder().name("test").build();
//
// given(groupExhibitRepository.findById(any())).willReturn(Optional.of(test));
//
// GroupExhibitInfoResponse response = groupExhibitService.getGroupExhibitInfo(0L);
//
// Assertions.assertEquals(test.getName(), response.getName());
// }
//
// @Test
// @DisplayName("Get All USer Group Exhibit")
// void getAllUserGroupExhibit() {
// GroupExhibit test = GroupExhibit.builder().name("test").build();
// Member member = Member.builder().groupExhibit(test).build();
// List<Member> members = new ArrayList<>();
// members.add(member);
//
// given(memberRepository.findAllByUserId(anyLong())).willReturn(members);
//
// GroupExhibitInfoResponses responses = groupExhibitService.getAllUserGroupExhibitInfo(0L);
// String name = responses.getGroupExhibitResponses().get(0).getName();
//
// Assertions.assertEquals(test.getName(), name);
// }
//
// @Test
// @DisplayName("Get Group Exhibit Users")
// void getGroupExhibitUsers() {
//
// Member member1 = Member.builder().user(User.builder().name("test1").build()).build();
// Member member2 = Member.builder().user(User.builder().name("test2").build()).build();
// Manager manager = Manager.builder().user(User.builder().name("test3").build()).build();
//
// GroupExhibit test = GroupExhibit.builder().name("test").build();
// test.addMember(member1);
// test.addMember(member2);
// test.addManger(manager);
//
// given(groupExhibitRepository.findById(any())).willReturn(Optional.of(test));
//
// GroupExhibitUserResponses responses = groupExhibitService.getGroupExhibitUsers(0L, 0L);
// String username = responses.getGroupExhibitUserResponses().get(0).getUserInfoResponse().getName();
//
// Assertions.assertEquals("test3", username);
// }
//
// @Test
// @DisplayName("Add Exhibit")
// void addExhibit() {
// GroupExhibit test = GroupExhibit.builder().name("test").build();
// Exhibit exhibit = Exhibit.builder().build();
// User user = User.builder().build();
//
// given(groupExhibitRepository.findById(anyLong())).willReturn(Optional.of(test));
// given(exhibitService.getExhibitById(anyLong())).willReturn(exhibit);
// given(userService.getUserById(anyLong())).willReturn(user);
//
// groupExhibitService.addExhibit(0L, 0L, 0L);
//
// verify(groupExhibitRepository).save(any());
// }
//
// @Test
// @DisplayName("Add Manager")
// void addManager() {
// User fromUser = User.builder().name("from").build();
// User toUser = User.builder().name("to").build();
// GroupExhibit test = GroupExhibit.builder().name("test").build();
//
// given(userService.getUserById(0L)).willReturn(fromUser);
// given(userService.getUserById(1L)).willReturn(toUser);
// given(groupExhibitRepository.findById(anyLong())).willReturn(Optional.of(test));
//
// groupExhibitService.addManager(0L, 1L, 0L);
//
// verify(groupExhibitRepository).save(any());
// }
//}
Loading