Fix broken footer links pointing to "#" (#108)#176
Merged
Sendi0011 merged 2 commits intoJul 21, 2026
Conversation
- Link GitHub icon to the actual repo (opens in new tab) - Mark Twitter and Discord as 'Coming soon' (disabled, styled distinctly) until real handles are confirmed - Add placeholder /privacy and /terms pages with 'Coming soon' notices - Update footer to link Privacy Policy / Terms of Service to the new pages Closes JointSave-org#108
Contributor
|
@temisan0x kindly fix failing ci |
Contributor
Author
|
Hi @Sendi0011, I have made fixes. Kindly review. |
Sendi0011
self-requested a review
July 19, 2026 09:43
Sendi0011
approved these changes
Jul 21, 2026
Sendi0011
left a comment
Sendi0011
left a comment
Contributor
There was a problem hiding this comment.
Great work @temisan0x
LGTM
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108
Summary
Removes all dead
href="#"links from the footer. GitHub now points to the real repo, Twitter/Discord are clearly marked as "coming soon" rather than silently doing nothing, and Privacy Policy / Terms of Service link to new placeholder pages.Changes
https://github.com/JointSave-org/Joint_Save, opens in a new tab (target="_blank" rel="noopener noreferrer").ARCHITECTURE.md, is Stellar's own, not JointSave's). Rather than leave these ashref="#", they're now rendered as disabled, greyed-out text labeled "Coming soon" (aria-disabled="true"), per the issue's fallback guidance. Easy to swap in real links once confirmed./privacyand/termspages with a "Coming soon" notice, styled to match the existingnot-found.tsxpage (header, logo, back-to-home link).Open questions for a maintainer
/privacyand/termsstay as placeholders, or link out to an existing doc (e.g. Notion) if one exists?Testing
Verified locally via
npm run dev:href="#"remaining infooter.tsx/privacyand/termsrender correctly