Humoud AlGhanim - Resynced the fork then pushed again#14
Closed
HAlGhanim wants to merge 2 commits intoJoinCODED:mainfrom
Closed
Humoud AlGhanim - Resynced the fork then pushed again#14HAlGhanim wants to merge 2 commits intoJoinCODED:mainfrom
HAlGhanim wants to merge 2 commits intoJoinCODED:mainfrom
Conversation
taqillion
reviewed
Mar 6, 2025
src/variables.ts
Outdated
| let ageString: string; | ||
| let hobbyString: string; | ||
| let fullNameString: string = `My name is ${fullName}`; | ||
| let ageString: string = `I am ${2025 - yearOfBirth}`; |
Contributor
There was a problem hiding this comment.
This code works today, works tomorrow and will work next month. But will it work next year?
Think about how we can make it always work.
Author
|
Placed the current year in a variable that fetches the current year instead
of hardcoding a number
…On Thu, Mar 6, 2025 at 1:58 PM A-Taqi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/variables.ts
<#14 (comment)>
:
> @@ -25,9 +26,9 @@ let image: string;
* 3. hobbyString -> assign it: "My hobby is {YOUR_HOBBY}""
*/
-let fullNameString: string;
-let ageString: string;
-let hobbyString: string;
+let fullNameString: string = `My name is ${fullName}`;
+let ageString: string = `I am ${2025 - yearOfBirth}`;
This code works today, works tomorrow and will work next month. But will
it work next year?
Think about how we can make it always work.
—
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4HT7OXYQMHPY3R2YLCIWQ32TAS7FAVCNFSM6AAAAABYOL5THOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRUGA4TCNZSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.