Open
Conversation
…chaining in line 33 to work
Octowl
reviewed
Mar 9, 2025
| author: author, | ||
| publishedYear: publishedYear, | ||
| genre: genre, | ||
| }; // replace "{} as Book" with what you see is fit |
Contributor
There was a problem hiding this comment.
A fun thing you can do in JS: if the key and the variable share the same name you can do:
return {
title,
author,
publishedYear,
genre
};
Octowl
reviewed
Mar 9, 2025
Contributor
Octowl
left a comment
Octowl
left a comment
There was a problem hiding this comment.
This PR made me realise I'm missing an edge condition for this task. I've now made it slightly harder and doubled the size of the test suite 😬
Octowl
reviewed
Mar 9, 2025
|
|
||
| book.reviews | ||
| ? book.reviews.push({ reviewer: reviewer, comment: comment }) | ||
| : (book.reviews = [{ reviewer: reviewer, comment: comment }]); |
Contributor
There was a problem hiding this comment.
Ternary operators should only really be used as expressions (where the entire ternary operator will be replaced with a value. They should not have side-effects or be used as a general replacement for if statements.
A better ternary use here would be:
const newReview: Review = { reviewer, comment };
book.reviews =
book.reviews ? [...book.reviews, newReview] : [newReview];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.