Fix: shadowed currentstreak - #1457
Merged
JiyaBatra merged 7 commits intoAug 10, 2026
Merged
Conversation
|
@Saubhagya1621 is attempting to deploy a commit to the jiya's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for codevibeforyou ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Related Issue
Closes: #1451
📌 Description
Fixes a variable-shadowing bug in
completeLessonwhere the streak used to calculate the XP multiplier was different from the streak actually persisted to the database. This could cause a user's XP bonus to be based on one streak value while their saved/displayedcurrentStreakreflected a different one.✨ Changes Made
const currentStreak = getLearningStreak(events)block that shadowed the outer, already-computedcurrentStreak(date-diff based).currentStreak, so the reward and the persisted streak can no longer diverge.📷 Screenshots
N/A - backend logic fix, no UI change
🧪 Type of Change
✔️ Checklist
🚨 Notes for Contributors