Skip to content

Commit

Permalink
Fix double send of MAV_CMD_PREFLIGHT_CALIBRATION
Browse files Browse the repository at this point in the history
  • Loading branch information
DonLakeFlyer committed Feb 22, 2021
1 parent 84dd94b commit 59eba1b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 8 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ Note: This file only contains high level features or important fixes.

## 4.1 - Daily build

### 4.1.2 - Not yet released
* Bug: Radio setup - Fix double send of `MAV_CMD_PREFLIGHT_CALIBRATION` causing "Unable to send command" error.

### 4.1.1 - Stable
* Fix TCP link comms

### 4.1.0

* Support simple cameras which only support DIGICAM_CONTROL in the Photo/Video control on Fly View.
* Load Parameters From File: Support loading parameters which don't currently existing on the vehicle.
* Load Parameters From File: Add dialog which shows diff of file and vehicle params. Selective param upload from file.
Expand Down
4 changes: 0 additions & 4 deletions src/AutoPilotPlugins/Common/RadioComponentController.cc
Original file line number Diff line number Diff line change
Expand Up @@ -700,10 +700,6 @@ void RadioComponentController::_writeCalibration(void)
{
if (!_uas) return;

if (_px4Vehicle()) {
_vehicle->stopCalibration();
}

if (!_px4Vehicle() && (_vehicle->vehicleType() == MAV_TYPE_HELICOPTER || _vehicle->multiRotor()) && _rgChannelInfo[_rgFunctionChannelMapping[rcCalFunctionThrottle]].reversed) {
// A reversed throttle could lead to dangerous power up issues if the firmware doesn't handle it absolutely correctly in all places.
// So in this case fail the calibration for anything other than PX4 which is known to be able to handle this correctly.
Expand Down

0 comments on commit 59eba1b

Please sign in to comment.