Use WRAP_LIMIT to limit the width of tooltip signatures #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And here's the division by 3. |
|
@dawedawe Could you please rebase to |
dawedawe
force-pushed
the
use_gettooltip_width
branch
from
4b96c79 to
d731d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of dotnet/fsharp#14891 to squash tooltip signatures if they are longer than WRAP_LIMIT
Of course, it's a bit of a question of personal taste, but we could even use a smaller width like
WRAP_LIMIT/4to be even more readableCurrent:
This PR with WRAP_LIMIT=120
This PR with WRAP_LIMIT / 4
