Implement KT-73565 and basic box tests for memcpy, memmove, memset and memcmp intrinsics #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding some changes to this, i wasn't happy with the names of the extension functions for |
KitsuneAlex
commented
Dec 9, 2024
| import kotlin.collections.set | ||
| import kotlin.collections.sortedBy | ||
| import kotlin.collections.toList | ||
| import kotlin.collections.toTypedArray |
There was a problem hiding this comment.
Don't know why my formatter did this with the project settings.. can fix if desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the associated YouTrack issue, this PR aims to add memory intrinsics for Kotlin/Native for functions such as memset, memcpy, memmove and memcmp (throught libc). This allows optimizing a lot of per-element loop based functions with much faster optimized code.
I also implemented a public API for the intrinsics, supporting both untyped NativePointed addresses, and type safe extension functions for
CPointer.Very basic tests have been implemented in
kt73565.ktfor every function to make sure they work.If you have any comments or nitpicks, feel free to let me know.
Cheers.