Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW ONLY] Extract :showcase module #742

Draft
wants to merge 41 commits into
base: main
Choose a base branch
from
Draft

[REVIEW ONLY] Extract :showcase module #742

wants to merge 41 commits into from

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Jan 14, 2025 •
edited
Loading

image
image
image
image

hamen added 25 commits January 7, 2025 11:44
@hamen
extract Banners
75fd3c7 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Borders
5225f7d 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Buttons
0a06d86 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Checkboxes
34ef555 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Chips and Trees
9dd0025 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Dropdowns
a1fb38e 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Icons
c4d34c8 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Links
cafe158 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract ProgressBar
5fe1e2b 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract RadioButtons
a13867d 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Scrollbars
8220da1 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract SegmentedControls
5739c41 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Sliders
c9dd544 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract SplitLayouts
d20b11a 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Tabs
fb6f1f4 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract TextAreas
f7895c0 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract TextFields
080b403 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract Tooltips
53ff449 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract MarkdownDemo
d047024 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
workout dependencies in IDE plugin
a91bcb3 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract MarkdownView
36d8c69 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
extract ComponentsView
90f0a00 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
add Showcase dialog in IDE plugin
5787a9c 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
add ComponentsView to SwingComparisonTabPanel
a2fbd5b 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen
rollback a bunch of stuff
14982f9 
Signed-off-by: Ivan Morgillo <[email protected]>
@hamen hamen self-assigned this Jan 14, 2025
@hamen hamen requested a review from rock3r January 14, 2025 15:18
@hamen hamen changed the title [DON'T REVEW] Extract :showcase module [REVIEW ONLY] Extract :showcase module Jan 14, 2025
rock3r
rock3r requested changes Jan 17, 2025
View reviewed changes
samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Links.kt Outdated Show resolved Hide resolved
samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/Links.kt Outdated Show resolved Hide resolved
...ase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/StandaloneSampleIcons.kt Outdated Show resolved Hide resolved
samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/components/TextFields.kt Outdated Show resolved Hide resolved
samples/showcase/src/main/kotlin/org/jetbrains/jewel/samples/showcase/views/ComponentsView.kt Outdated Show resolved Hide resolved
...standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/viewmodel/MainViewModel.kt Outdated Show resolved Hide resolved
...standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/markdown/MarkdownEditor.kt Outdated Show resolved Hide resolved
...tandalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/markdown/MarkdownPreview.kt Outdated Show resolved Hide resolved
samples/standalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/view/MarkdownView.kt Outdated Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/styling/IconButtonStyling.kt Outdated Show resolved Hide resolved
rock3r
rock3r reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still comments to address

...tandalone/src/main/kotlin/org/jetbrains/jewel/samples/standalone/markdown/MarkdownPreview.kt Outdated Show resolved Hide resolved
rock3r
rock3r approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r rock3r approved these changes

Assignees

@hamen hamen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamen @rock3r