Fix list combo box tests #724
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split the editable and non-editable list combo boxes * Fix up item state management as it was utter chaos * Use the appropriate names for style items * Add iconTextGap to list item metrics * Only do preview selection when mouse-moving over an item, not when hovering, to reduce glitches when scrolling * Fix margins and colours
Mostly state being lost in recompositions, and recompositions happening when they shouldn't.
rock3r
added
bug
hamen
approved these changes
Dec 11, 2024
ui-tests/src/test/kotlin/org/jetbrains/jewel/ui/component/ListComboBoxUiTest.kt
Show resolved
Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/EditableComboBox.kt
Outdated
Show resolved
Hide resolved
hamen
added a commit
to rock3r/intellij-community
that referenced
this pull request
Jan 16, 2025
|
Migrated to IJP as JetBrains/intellij-community#2912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes tests pass by fixing a number of bugs, improves the component behaviour, and maintaining tests as needed.