Fix SCL-24273: JAR class resolution with special characters in filenames #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual jar:file: URL construction with proper Path.toUri() conversion to handle JAR filenames containing special characters (#, spaces, @, &, +, %). - Add SafeJarLoader utility with proper URI encoding and fallback mechanisms - Fix LibraryExt.jarUrls in package.scala to use SafeJarLoader.createJarUrl - Fix Artifact.readProperty to use SafeJarLoader.createJarResourceUrlFromUri - Fix compiler-shared package.scala readProperty with proper URI encoding - Fix ScalaMavenImporter to use Paths.get().toUri() for JAR URLs - Add comprehensive test coverage for special character scenarios - Maintain full backward compatibility The root cause was manual URL construction like `new URL(s"jar:file://$path")` instead of using Java's standard Path→URI conversion APIs, causing malformed URLs that URLClassLoader couldn't handle. This fix uses proper RFC 3986 URI encoding via Path.toUri().toURL() with robust error handling and detailed logging for troubleshooting.
|
Thanks for the PR, we will try to look into it this week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JAR URL encoding for special characters
Fixes SCL-24273: Classes decompiled from JAR files with special characters in their names are not resolved.
Problem
Manual JAR URL construction like
new URL(s"jar:file://$path!/")fails when filenames contain special characters (spaces, #, @, &, +, %) due to improper encoding.Solution
Replace manual URL construction with standard Java APIs:
Path.toUri().toURL()for proper RFC 3986 URI encodingTesting
This uses the same approach already used throughout the IntelliJ Scala codebase for proper URL encoding.