Skip to content

Conversation

Alex1005a
Copy link
Contributor

There are some cases when the type parameter is not inferred, and hint simply displays a type variable, for example A_. I'll try to figure out these cases, but what to do if the type variable is not inferred: show as is or don't display the hint at all?

@unkarjedy
Copy link
Member

Hello!
Thanks for the contribution! We will take a look.

A general comment, please get familiar with these guidelines:
https://github.com/JetBrains/intellij-scala/blob/idea251.x/CONTRIBUTING.md#guidelines-for-code-commits-and-pull-requests, including the examples of the commit messages.

@unkarjedy unkarjedy requested a review from pavelfatin May 13, 2025 07:57
@Alex1005a Alex1005a force-pushed the idea251.x-scl-23855 branch from 1bd8fb1 to 3e6a035 Compare May 13, 2025 19:16
@unkarjedy
Copy link
Member

@pavelfatin Kind ping

@unkarjedy
Copy link
Member

Sorry, it takes us longer to start looking into it due to other priorities, but we will get back to it soon.

@SrTobi SrTobi self-assigned this Sep 22, 2025
@SrTobi
Copy link
Contributor

SrTobi commented Sep 23, 2025

Hi @Alex1005a, I took your pr, reworked it a little bit and merged it already (See c29aa14..b301458). I fixed some stuff regarding infix calls and apply calls. Regarding the not-inferred types, I just used ScType.removeAbstracts, which has the scala compiler semantic in choosing either the upper or lower bound. I also added tests.

Do you have more examples where it didn't quite work for you? That would be helpful to fix further bugs

@SrTobi SrTobi closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants