[JEWEL-748] Define delimited inlines extension API, implement strikethrough #2915
+1,053
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
force-pushed
the
sebp/delimited-api
branch
from
f97e5c0 to
34d01b5
Compare
rock3r
force-pushed
the
sebp/delimited-api
branch
from
969c7cb to
5a258ca
Compare
|
This cannot be cherry-picked as there is following error: Maybe rebase on latest community master will help? |
|
On it ⌛ UPDATE: |
hamen
force-pushed
the
sebp/delimited-api
branch
from
43ec38e to
2243ea2
Compare
...src/main/kotlin/org/jetbrains/jewel/intui/markdown/standalone/IntUiProvideMarkdownStyling.kt
Outdated
Show resolved
Hide resolved
...ng/src/main/kotlin/org/jetbrains/jewel/intui/markdown/bridge/BridgeProvideMarkdownStyling.kt
Outdated
Show resolved
Hide resolved
...wel/markdown/ide-laf-bridge-styling/intellij.platform.jewel.markdown.ideLafBridgeStyling.iml
Outdated
Show resolved
Hide resolved
...rkdown/int-ui-standalone-styling/intellij.platform.jewel.markdown.intUiStandaloneStyling.iml
Outdated
Show resolved
Hide resolved
...rkdown/int-ui-standalone-styling/intellij.platform.jewel.markdown.intUiStandaloneStyling.iml
Outdated
Show resolved
Hide resolved
|
I reckon Ivan got tangled up in the rebase somewhere, let me fix these... |
rock3r
commented
Feb 10, 2025
...ewel/markdown/extension/gfm-tables/intellij.platform.jewel.markdown.extension.gfm-tables.iml
Outdated
Show resolved
Hide resolved
|
@AlexVanGogen should have fixed the bad rebase, and have renamed the module as requested for consistency :) |
rock3r
force-pushed
the
sebp/delimited-api
branch
from
9779443 to
c38198c
Compare
|
I ended up doing a clean-slate squash/rebase because there was too much random crap in the history, plus the fun conflicts that just showed up... |
rock3r
force-pushed
the
sebp/delimited-api
branch
3 times, most recently
from
f01874b to
30e9002
Compare
...ng/src/main/kotlin/org/jetbrains/jewel/intui/markdown/bridge/BridgeProvideMarkdownStyling.kt
Show resolved
Hide resolved
…hrough This includes a bunch of changes to the Markdown inline APIs to better align with CommonMark and our actual needs; a clean-up of the previous half-hearted attempt at supporting custom inline nodes (it did not and could never have worked in the way it was implemented), and some misc tweaks and cleanup.
rock3r
force-pushed
the
sebp/delimited-api
branch
from
30e9002 to
9e598b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a bunch of changes to the Markdown inline APIs to better align with CommonMark and our actual needs; a clean-up of the previous half-hearted attempt at supporting custom inline nodes (it did not and could never have worked in the way it was implemented), and some misc tweaks and cleanup.
This PR also includes a fix to the pre-push hook to work in the IJP repo.
Superseeds JetBrains/jewel#748
Caution
Requires #2913 to be merged first