Fix SearchBar PredictiveBack's animation when a back action was canceled. #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led. It is not possible to run a suspend function when the progress flow is canceled because the onBack suspend lambda is canceled as well. https://android-review.googlesource.com/c/platform/frameworks/support/+/3454206
|
Please, cherry-pick the commit from AOSP and push it to jb-main (without squashing the PR to preserve the commit). As for release notes - I assume we don't need them, as we didn't release PredictiveBack yet? P.S. The previous approach was to not add release notes from AOSP commits, as AOSP itself should has it. Though, we probably need to change that. For example by creating a PR with Release Notes as here, but not squashing it, just pushing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to run a suspend function when the progress flow is canceled because the onBack suspend lambda is canceled as well.
https://android-review.googlesource.com/c/platform/frameworks/support/+/3454206
Release Notes
Fixes - Multiple Platforms